Utilize existing HDPath class spec - Githubissues

ApeWorX / ape-ledger

Ledger Nano S and X account plugin for the Ape Framework

https://www.apeworx.io/

Apache License 2.0

6 stars 7 forks source link

Utilize existing HDPath class spec #6

Open antazoey opened 3 years ago

antazoey commented 3 years ago

Overview

Try to use checkout https://github.com/ethereum/eth-account/blob/bd3dc2c0e85934b9c47980053d9f1d16a7540990/eth_account/hdaccount/deterministic.py#L187 for HDPath instead of using our own implementation.

Keep in mind that ours is a bit ledger-specific, so we may need to subclass or something.

Specification

Rely on checkout https://github.com/ethereum/eth-account/blob/bd3dc2c0e85934b9c47980053d9f1d16a7540990/eth_account/hdaccount/deterministic.py#L187 for path validation (and class definition).

Just try (maybe a spike?)

Dependencies

Include links to any open issues that must be resolved before this feature can be implemented.