fix: transaction type detection [APE-485] - Githubissues

ApeWorX / ape-optimism

Optimism network provider plugin for the Ape Framework

https://www.apeworx.io/

Apache License 2.0

9 stars 9 forks source link

fix: transaction type detection [APE-485] #15

Closed z80dev closed 1 year ago

z80dev commented 1 year ago

What I did

Fixed transaction type detection

How I did it

Updated logic in create_transaction to match updates made in ape-ethereum in

https://github.com/ApeWorX/ape/pull/1247/files

Now uses the built-in conversion manager to parse for transaction type

How to verify it

Checklist

[x] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

antazoey commented 1 year ago

Please add a test next time.