fix: various issues with propose cli - Githubissues

ApeWorX / ape-safe

Safe (Wallet) account plugin for the Ape Framework

https://www.apeworx.io/

Apache License 2.0

14 stars 8 forks source link

fix: various issues with propose cli #24

Closed antazoey closed 10 months ago

antazoey commented 10 months ago

What I did

fix: issue with propose execution, sender is required for initial proposal but doesnt mean we want to execute
gas price was not settable
account state was lost - i think only really matter with MockClient - but fixed
missing success log when proposing
filled in some tests surrounding the propose command but benefits i think all command
handle some 0.7.1 upgrades

coing up next, ill look at approve, add tests, and fill in any gaps there.

How I did it

How to verify it

Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)