fix: estimate gas - Githubissues

ApeWorX / ape-safe

Safe (Wallet) account plugin for the Ape Framework

https://www.apeworx.io/

Apache License 2.0

14 stars 8 forks source link

Closed antazoey closed 8 months ago

antazoey commented 8 months ago

NOTE: Is only a POV - I havent tested yet. fixes: #36

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

fubuloubu commented 8 months ago

This seems to work well for me, but needs some update to the mock provider

solarthesis commented 8 months ago

does this fix the need to provide gas=0 ?

antazoey commented 8 months ago

the tests fail on main for the same reason; not sure what changed or why that suddenly happens.

antazoey commented 8 months ago

shipppppp itttttttttttt

solarthesis commented 8 months ago

this is never gonna ship @antazoey forget about it

antazoey commented 8 months ago

this is never gonna ship @antazoey forget about it

why do you say this?