solarthesis commented 5 months ago

Environment information

ape and plugin versions:

$ ape --version
0.7.23

$ ape plugins list
Installed Plugins
  alchemy      0.7.3
  etherscan    0.7.4
  foundry      0.7.5
  optimism     0.7.3
  safe         0.7.0b2
  solidity     0.7.3

Python Version: 3.12 b- OS: osx/linux/win linux

What went wrong?

The safe api changed for fetching transactions, i believe v1/safes/{address}/transactions/ no longer works and is now https://safe-transaction-optimism.safe.global/ /v1/safes/{address}/all-transactions/

https://github.com/ApeWorX/ape-safe/blob/eddc804f771b791d3891d3cfe6245edc98f90cf8/ape_safe/client/__init__.py#L84

Please include information like:

what command you ran

txn            = multisend.MultiSend()
txn(sender=self.safe,gas=0,submit_transaction=False,nonce=nonce)

Trying to push

the code that caused the failure (see this link for help with formatting code)

full output of the error you received


Traceback (most recent call last):
File "/home/thesis/repos/gnosis_perp_ape/main.py", line 58, in <module>
self.setup_gnosis_perp_parameter_change(args.p)
File "/home/thesis/repos/gnosis_perp_ape/utils/controller.py", line 75, in setup_gnosis_perp_parameter_change
self.post_gnosis_transaction(contractName='perp_settings',functionName=functionName,args=stagedParams)    
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/thesis/repos/gnosis_perp_ape/utils/gnosis_safe.py", line 24, in wrapper
return func(self,*args, **kwargs)
       ^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/thesis/repos/gnosis_perp_ape/utils/gnosis_safe.py", line 64, in post_gnosis_transaction
nonce          = self.get_next_safe_nonce()
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/thesis/repos/gnosis_perp_ape/utils/gnosis_safe.py", line 24, in wrapper
return func(self,*args, **kwargs)
       ^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/thesis/repos/gnosis_perp_ape/utils/gnosis_safe.py", line 60, in get_next_safe_nonce
return self.safe.new_nonce
       ^^^^^^^^^^^^^^^^^^^
File "/home/thesis/miniconda3/envs/gnosis_perp_ape/lib/python3.12/site-packages/ape_safe/accounts.py", line 322, in new_nonce
if latest_tx := next(self.client.get_transactions(confirmed=False), None):
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/thesis/miniconda3/envs/gnosis_perp_ape/lib/python3.12/site-packages/ape_safe/client/base.py", line 81, in get_transactions
for txn in self._all_transactions():
File "/home/thesis/miniconda3/envs/gnosis_perp_ape/lib/python3.12/site-packages/ape_safe/client/__init__.py", line 86, in _all_transactions
response = self._get(url)
           ^^^^^^^^^^^^^^
File "/home/thesis/miniconda3/envs/gnosis_perp_ape/lib/python3.12/site-packages/ape_safe/client/base.py", line 128, in _get
return self._request("GET", url)
       ^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/thesis/miniconda3/envs/gnosis_perp_ape/lib/python3.12/site-packages/ape_safe/client/base.py", line 153, in _request
raise ClientResponseError(api_url, response)
ape_safe.exceptions.ClientResponseError: Exception when calling 'https://safe-transaction-optimism.safe.global/api/v1/safes/xxxxxxxxxxxxxxxxxxxxx/transactions/':

<!doctype html>

Not Found

The requested resource was not found on this server.


### How can it be fixed?

Need to update the api

linear[bot] commented 5 months ago

APE-1749 Api Update

fubuloubu commented 5 months ago

@solarthesis please check out https://github.com/ApeWorX/ape-safe/pull/47 and let me know if that solves your problem!

ApeWorX / ape-safe

Api Update #46

Environment information

What went wrong?

Not Found