fix: issue with extra suffix parts in imported sources

antazoey commented 3 months ago

What I did

issue where could not compile contracts that imports contracts with deeper suffixes. for example if you are compiling Contract.sol and it was using Contract.v1.sol, it would fail because ape-solidity is only registered for .sol and not v1.sol.

This makes it work.

requires this though https://github.com/ApeWorX/ape/pull/2123

also fixes a bug where flattening mistook some things in comments for import statements and hell broke loose

How I did it

How to verify it

Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

antazoey commented 3 months ago

As always, only getting this error in CI/CD and not locally.

dtdang commented 3 months ago

As always, only getting this error in CI/CD and not locally.

Ran this locally and also got the same error on the same test on my end.

antazoey commented 3 months ago

OK turns out it was a real bug with flattening. Should be good now, ill make sure it is also mentioned in the release notes.

ApeWorX / ape-solidity