ApeWorX / ape-vyper

Vyper compiler plugin for the Ape Framework, using VVM
https://www.apeworx.io/
Apache License 2.0
26 stars 9 forks source link

fix: Vyper source map fixes [APE-1321] #92

Closed antazoey closed 1 year ago

antazoey commented 1 year ago

What I did

Fixes various things in the plugin preventing dev message checks from working as well as many of the builtin-errors, which we get from the error map on version 0.3.9.

fixes: #90 Fixes: APE-1320 Fixes: APE-1321

How I did it

How to verify it

Checklist

banteg commented 1 year ago

fixes: 0.3.8, 0.3.9, 0.3.10 breaks: 0.2.1, 0.2.2, 0.2.3, 0.2.15, 0.2.16, 0.3.0, 0.3.1, 0.3.2, 0.3.3, 0.3.4

# regressions
-0.2.1 success
+0.2.1 Could not find the source of the revert.
-0.2.2 success
+0.2.2 Could not find the source of the revert.
-0.2.3 success
+0.2.3 Could not find the source of the revert.
# different error
-0.2.4 Could not fetch contract at '0x6c992966be10e1da52fb2b09a62a1059c093bf' to check dev message.
+0.2.4 Could not find the source of the revert.
# no change
 0.2.5 Could not find the source of the revert.
 0.2.7 Could not find the source of the revert.
 0.2.8 Could not find the source of the revert.
 0.2.11 Could not find the source of the revert.
 0.2.12 Could not find the source of the revert.
# regressions
-0.2.15 success
+0.2.15 Could not find the source of the revert.
-0.2.16 success
+0.2.16 Could not find the source of the revert.
-0.3.0 success
+0.3.0 Could not find the source of the revert.
-0.3.1 success
+0.3.1 Could not find the source of the revert.
-0.3.2 success
+0.3.2 Could not find the source of the revert.
-0.3.3 success
+0.3.3 Could not find the source of the revert.
-0.3.4 success
+0.3.4 Could not find the source of the revert.
# no change
 0.3.6 success
 0.3.7 success
# improvements
-0.3.8 Could not find the source of the revert.
+0.3.8 success
-0.3.9 Could not find the source of the revert.
+0.3.9 success
-0.3.10 Expected dev revert message 'dev: assert not 2' but got 'dev: BAD_CALLDATASIZE_OR_CALLVALUE'.
+0.3.10 success
antazoey commented 1 year ago

breaks: 0.2.1, 0.2.2, 0.2.3, 0.2.15, 0.2.16, 0.3.0, 0.3.1, 0.3.2, 0.3.3, 0.3.4

Try now!