ApeWorX / ape

The smart contract development tool for Pythonistas, Data Scientists, and Security Professionals
https://apeworx.io
Apache License 2.0
890 stars 131 forks source link

`parse_type` is buggy #1122

Closed nazariyv closed 2 years ago

nazariyv commented 2 years ago

Environment information

Installed Plugins:
  etherscan      0.5.2
  ens            0.5.1
  addressbook    0.5.0a1

But this bug has nothing to do with plugins

This also doesn't matter.

What went wrong?

ape-bug

And discord link to the above.

Essentially, this problem boils down to the fact that parse_type has a bug. I debugged it for a little while, but then realised that there is an easier way to solve the problem. There is no need to go from canonical type string back to Python representation. There is an ABIType that can be easily utilised to produce what parse_type was producing, but bug free.

How can it be fixed?

Going to link the fix here shortly.

antazoey commented 2 years ago

Transaction hash that fails: 0x998f1810cc06f7c0aa3a6094082278e882a53a35a57a4f1094213ec78ca45931