ApeWorX / ape

The smart contract development tool for Pythonistas, Data Scientists, and Security Professionals
https://apeworx.io
Apache License 2.0
892 stars 131 forks source link

add get_version_map to ape-vyper plugin #850

Closed sabotagebeats closed 2 years ago

sabotagebeats commented 2 years ago

Overview

cls.compiler_manager.registered_compilers['.vy'].get_version_map(source_paths) doesn't work on vyper because vyper plugin doesn't have get_version_map()

Specification

Describe the syntax and semantics of how you would like to see this feature implemented. The more detailed the better!

Remember, your feature is much more likely to be included if it does not involve any breaking changes.

should be in the plugin

Dependencies

Include links to any open issues that must be resolved before this feature can be implemented.

antazoey commented 2 years ago

We should probably make get_version_map an API method if it isn't already

sabotagebeats commented 2 years ago

We should probably make get_version_map an API method if it isn't already

get_version_map works on solidity but it throws an error it doesn't exist in vyper

antazoey commented 2 years ago

@sabotagebeats get_version_map is more of an implementation detail in the Solidity plugin for other features, that is why its not in ape-vyper. It is not part of the Compiler API so it is not expected to be implemented. However, you need this functionality, so there is an argument to add it to CompilerAPI.

Otherwise, from a plugin perspective, all you need to do is create a JSON file in the build directory; it does not matter how you do it. It may look different from compiler to compiler.

sabotagebeats commented 2 years ago

Sprint 3 Feedback: Still in research and design

antazoey commented 2 years ago
antazoey commented 2 years ago

Not needed!