EIP712_DOMAIN_FIELDS constant is missing a field member salt as defined in the EIP712 specification.
Value:
In an increasingly multi-chain world, salt is needed to prevent signatures being used inappropriately on other chains.
For example, deploying a contract at the same address on Ethereum and Harmony which utilizes EIP-2612, could result in malicious reuse of signatures. This is due to the fact that the CHAIN_ID opcode returns a value of 1 on Harmony, the same as Ethereum. Adding this field member to the EIP712_DOMAIN_FIELDS constant will allow for the creation of valid signatures using this library for contracts which utilize the salt field.
Dependencies:
N/A
Design approach:
N/A
Task list:
[x] Add salt field member
Estimated completion date:
Soon
Design review:
Do not signoff unless: 1) agreed the tasks and design approach will achieve acceptance and 2) the work can be completed by one person within the SLA. Design reviewers should consider simpler approaches to achieve goals.
Elevator pitch:
EIP712_DOMAIN_FIELDSconstant is missing a field membersaltas defined in the EIP712 specification.Value:
In an increasingly multi-chain world,
saltis needed to prevent signatures being used inappropriately on other chains. For example, deploying a contract at the same address on Ethereum and Harmony which utilizes EIP-2612, could result in malicious reuse of signatures. This is due to the fact that theCHAIN_IDopcode returns a value of 1 on Harmony, the same as Ethereum. Adding this field member to theEIP712_DOMAIN_FIELDSconstant will allow for the creation of valid signatures using this library for contracts which utilize thesaltfield.Dependencies:
N/A
Design approach:
N/A
Task list:
saltfield memberEstimated completion date:
Soon
Design review:
Do not signoff unless: 1) agreed the tasks and design approach will achieve acceptance and 2) the work can be completed by one person within the SLA. Design reviewers should consider simpler approaches to achieve goals.
(Please leave a comment to sign off)