ApeWorX / eip712

Message classes for typed structured data hashing and signing in Ethereum
Apache License 2.0
42 stars 19 forks source link

refactor!: replace string types with force-validated pydantic types #59

Open bitwise-constructs opened 1 month ago

bitwise-constructs commented 1 month ago

What I did

All the types used in EIP712 contracts are now using Pydantic annotated types with built-in validation

fixes: #22 Fixes: APE-1782

How I did it

This PR is being developed in coordination with an overhaul of the eth_pydantic_types library here: https://github.com/ApeWorX/eth-pydantic-types/pull/11

How to verify it

Checklist

bitwise-constructs commented 1 month ago

@antazoey 2 tests are broken but will be good to talk about tomorrow and get into how heavy to enforce the pydantic types

antazoey commented 1 month ago

it's comin' along!