ApeWorX / ethpm-types

Implementation of EIP-2678
Apache License 2.0
14 stars 8 forks source link

chore: drop python 3.8 support and upgrade ETH dependencies #118

Closed antazoey closed 3 weeks ago

antazoey commented 5 months ago

What I did

fixes: #

How I did it

How to verify it

Checklist

fubuloubu commented 5 months ago

related to the other discussion, I wonder if these lower-level packages than ape should stay 3.8 a little bit longer, enough time for those using ape to upgrade to 0.8 where py 3.8 is dropped

then we drop this closer to the deprecation date (maybe when we go v1.0 with ape)

antazoey commented 5 months ago

related to the other discussion, I wonder if these lower-level packages than ape should stay 3.8 a little bit longer, enough time for those using ape to upgrade to 0.8 where py 3.8 is dropped

then we drop this closer to the deprecation date (maybe when we go v1.0 with ape)

I am going back and forth. The main thing is I need the eth dependencies upgraded and I can't do that without also it being breaking (think Hexbytes change). So I need breaking changes releases for all these lower levels packages to even upgrade ape. I guess a chicken and egg problem.

antazoey commented 5 months ago

@fubuloubu OK here is a separate PR that add 3.12, so now it will support 3.8-3.12 withou breaking https://github.com/ApeWorX/ethpm-types/pull/119