search

ApeWorX / ethpm-types

Implementation of EIP-2678
Apache License 2.0
14 stars 8 forks source link

Pydantic ValidationError for ContractType runtimeByteCode and deploymentBytesCode #36

Closed antazoey closed 2 years ago

antazoey commented 2 years ago

Environment information

Latest ape

What went wrong?

When compiling yearn-vaults repo, I get an error about the value of runtimeBytecode not being valid hex.

the validation error comes from this line: https://github.com/ApeWorX/ethpm-types/blob/main/ethpm_types/utils.py#L17-L18

How can it be fixed?

antazoey commented 2 years ago

additional notes: the repo is very large and the values in this field are also very large

antazoey commented 2 years ago

@fubuloubu

antazoey commented 2 years ago

For some reason the two unexpected symbols that appear are _ and $

antazoey commented 2 years ago

I am guessing this has to do with the experimental ABI decoder

antazoey commented 2 years ago

The bin has sections surrounded by $__ and __$

fubuloubu commented 2 years ago

Have I mentioned how much I hate Solidity? https://docs.soliditylang.org/en/v0.8.14/using-the-compiler.html#library-linking

antazoey commented 2 years ago

Closing and fixing in ape-solidity