search

ApeWorX / ethpm-types

Implementation of EIP-2678
Apache License 2.0
14 stars 8 forks source link

fix: pin mypy to 0.982 #52

Closed ghost closed 1 year ago

ghost commented 1 year ago

Avoiding 0.990 as it's a breaking release

ghost commented 1 year ago

What would have to be updated to fix?

@fubuloubu Here's the changelog https://mypy-lang.blogspot.com/2022/11/mypy-0990-released.html

I'm not quite sure how much else really is a breaking change because I was getting a wall of errors from Mypy in ape-core on 0.990, with no errors on 0.982. Like there seemed to be more breaking issues than what the changelog suggests

antazoey commented 1 year ago

sure how much else really is a breaking change because I was getting a wall of errors from Mypy in ape-core on 0.990, with no errors on 0.982. Like there seemed to be more breaking issues than what the changelog suggests

We don't need to pin mypy everywhere necessarily, only in Core where the breaking changes are really affecting us. I am not sure how mypy upgrade is affecting every other package, but let's hard-pin it on an as-needed basis (perhaps) , and then somebody will upgrade mypy in core eventually.