feat: allow `dev` field to be set on `PCMapItem` [APE-783]

ApeWorX / ethpm-types

Implementation of EIP-2678

Apache License 2.0

14 stars 8 forks source link

feat: allow `dev` field to be set on `PCMapItem` [APE-783] #69

Closed antazoey closed 1 year ago

antazoey commented 1 year ago

What I did

for the benefit of checking compiler-injected messages, allow dev to be set on the PCMapItem instances

How I did it

How to verify it

Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

antazoey commented 1 year ago

Is this breaking?

I managed to avoid most breakage, but if you make an assertion on the raw __root__ of a PCMapItem, then that would no longer work. That is the only thing.

It does't break ape-vyper or ape though on its own; will triple check, but it really shouldn't.

fubuloubu commented 1 year ago

Is this breaking? It does't break ape-vyper or ape though on its own; will triple check, but it really shouldn't.

Okay, if it doesn't break when you check I am good to go