Add Address type - Githubissues

ApeWorX / evm-trace

Ethereum Virtual Machine transaction tracing tool

Apache License 2.0

299 stars 28 forks source link

Add Address type #15

Open NotPeopling2day opened 2 years ago

NotPeopling2day commented 2 years ago

Overview

While working on gas reporting, @fubuloubu mentioned wishing address type was more optimized. The original thought is to use an Address(HexBytes) class.

Specification

A little research is needed to see how well this fits with trace/gas reporting.

Dependencies

APE-58

fubuloubu commented 2 years ago

would be even nicer if it was just the same type that ape core uses, so conversion wasn't necessary

NotPeopling2day commented 3 months ago

@antazoey Should we use https://github.com/ApeWorX/eth-pydantic-types?tab=readme-ov-file#address for the address type issue? Or do you think we're okay how we're currently using address with eth_pydantic_types HexBytes?