ApeWorX / github-action

GitHub Actions CI File for Ape Projects
Apache License 2.0
6 stars 3 forks source link

feat: add way to install from remote branch or commit as well as renames [APE-1027] #20

Closed antazoey closed 1 year ago

antazoey commented 1 year ago

fixes: #18

Fixes: APE-1027

antazoey commented 1 year ago
antazoey commented 1 year ago

i did find a way to test this; you can use actions from branches in other repos

antazoey commented 1 year ago

can use with this branch to also instal remote plugins: feat/allow-installing-plugins-from-branches

    - uses: antazoey/github-action@feat/much-upgrade
      with:
        python-version: "3.10"
        ape-remote-git-version: "https://github.com/antazoey/ape.git@both"
        ape-plugins-list: vyper@git+https://github.com/antazoey/ape-vyper.git@test/cov
antazoey commented 1 year ago

I am trying to use this. I see it is installing everything correctly. The plugins actually are definitely correctly (from git+ remote). However, eth-ape still seems to be using an older version!! IDKW. It installs the new version but doesn't actually use it, what..in..the..heck

antazoey commented 1 year ago

btw my testing is happening here: https://github.com/antazoey/ape-playground/pull/1

antazoey commented 1 year ago

i think it not putting it in the hosted tool cache, and the binaries in the end comes from there so even if it installs it, it wont work unless it ends up in that cache. im not sure why it's not tho, maybe the cache key doesnt like some symbols from a URL..

antazoey commented 1 year ago

OH DANG

I figured it out....

so eth-ape when installing from a remote like this comes back with version 0.1.0 as the version.. then when you install any plugin, it overrides it and sets it to the latest..

dang... maybe can be fixed by including tags tho before installing the git+