ApeWorX / github-action

GitHub Actions CI File for Ape Projects
Apache License 2.0
6 stars 3 forks source link

`Path Validation Error` in Post Setup Ape [APE-1158] #23

Closed pcaversaccio closed 9 months ago

pcaversaccio commented 1 year ago

For replication, see this run and go to the section Post Setup Ape

Post job cleanup.
Post job cleanup.
Cache hit occurred on the primary key [3](https://github.com/pcaversaccio/snekmate/actions/runs/5430063261/jobs/9875534341#step:30:3).11-pip-, not saving cache.
Post job cleanup.
Post job cleanup.
Cache hit occurred on the primary key Linux-build-cache, not saving cache.
Post job cleanup.
Warning: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.
antazoey commented 1 year ago

I have also noticed this.

antazoey commented 9 months ago

Unfortunately the GitHub cache action requires archives to exist if you say you want to cache them. In our case:

  1. the .build won't exist if you are not compiling
  2. the .vvm won't exist if you are not using vyper
  3. the .solc won't exist if you are not using solc

There is no setting (yet) in the action to allow empty. Related issue: https://github.com/actions/cache/issues/1241

I have a workaround in place that creates empty directories if they do not exist (see https://github.com/ApeWorX/github-action/pull/27).

pcaversaccio commented 9 months ago

Unfortunately the GitHub cache action requires archives to exist if you say you want to cache them. In our case:

  1. the .build won't exist if you are not compiling
  2. the .vvm won't exist if you are not using vyper
  3. the .solc won't exist if you are not using solc

There is no setting (yet) in the action to allow empty. Related issue: actions/cache#1241

I have a workaround in place that creates empty directories if they do not exist (see #27).

Thanks for fixing it, but I'm not sure I can fully follow. In my case, for example, I'm using ape Vyper compilation here. Does this mean that just the .solc folder is missing (since I use compilation & Vyper) in that case and thus the warning is issued?

antazoey commented 9 months ago

Does this mean that just the .solc folder is missing (since I use compilation & Vyper) in that case and thus the warning is issued?

I believe that is the case. Do you mind checking if the fix has resolved the warning for you?

pcaversaccio commented 9 months ago

Does this mean that just the .solc folder is missing (since I use compilation & Vyper) in that case and thus the warning is issued?

I believe that is the case. Do you mind checking if the fix has resolved the warning for you?

Is it already released? If yes, I can simply retrigger the latest CI run for snekmate.

antazoey commented 9 months ago

Is it already released? If yes, I can simply retrigger the latest CI run for snekmate.

It is not released yet, but it's merged. I think you can use branches like this:

- uses: ApeWorX/github-action@main

But otherwise I noticed the WARNINGs are gone from the test runs of the action.

pcaversaccio commented 9 months ago

Is it already released? If yes, I can simply retrigger the latest CI run for snekmate.

It is not released yet, but it's merged. I think you can use branches like this:

- uses: ApeWorX/github-action@main

But otherwise I noticed the WARNINGs are gone from the test runs of the action.

I can confirm that the warnings are gone now: image

https://github.com/pcaversaccio/snekmate/actions/runs/7766317138/job/21182002650