fixes #111 - Githubissues

ApeWorX / py-solc-x

Python wrapper and version management tool for the solc Solidity compiler.

https://solcx.readthedocs.io/

MIT License

138 stars 48 forks source link

fixes #111 #112

Closed Macarse closed 3 years ago

Macarse commented 3 years ago

What I did

Found the source of the issue: https://github.com/ethereum/solc-bin/tree/gh-pages/windows-amd64

Starting 0.7.2 they are exes

Related issue: #111

How I did it

mmmm I don't know what you expect me to write here

How to verify it

I am not running windows

Checklist

[ ] I have confirmed that my PR passes all linting checks
[ ] I have included test cases
[ ] I have updated the documentation (README.md)
[ ] I have added an entry to the changelog

ok, I didn't do any of those. pytest failed

$ pytest tests
ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]
pytest: error: unrecognized arguments: --cov=solcx --cov-branch --cov-report
  inifile: /Users/x/dev/py-solc-x/setup.cfg
  rootdir: /Users/x/dev/py-solc-x

and I am not sure if I will be able to test windows behavior outside of windows.

iamdefinitelyahuman commented 3 years ago

Looks like this is failing at least in part due to an unrelated issue. I should be able to look at it soon. Thanks for your help with this!