ApeWorX / py-solc-x

Python wrapper and version management tool for the solc Solidity compiler.
https://solcx.readthedocs.io/
MIT License
138 stars 48 forks source link

import solc versions installed via solc-select #136

Closed f0rki closed 9 months ago

f0rki commented 2 years ago

What I did

Search the path used by solc-select for solidity versions to import.

Related issue: #122

How I did it

glob ~/.solc-select/artifacts for installed solc binaries.

How to verify it

$ rm -rf ~/.solcx ~/.solc-select
$ pip install solc-select
[...]
$ solc-select install 0.4.26 0.7.6
Installing '0.7.6'...
Version '0.7.6' installed.
Installing '0.4.26'...
Version '0.4.26' installed.
$ python -c 'import solcx; print(solcx.import_installed_solc())'
[Version('0.7.6'), Version('0.4.26')]

Checklist

f0rki commented 2 years ago

I am not sure on how to add test cases for this and whether this is even needed?

f0rki commented 2 years ago

Somewhat related: it might be a good idea to use symlinks when sharing a lot of solc versions with solc-select. But I am not sure, whether this results in other issues.

github-actions[bot] commented 9 months ago

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

github-actions[bot] commented 9 months ago

This PR was closed because it has been inactive for 35 days.