use shutil.move instead of os.rename to avoid crashes during install

ApeWorX / py-solc-x

Python wrapper and version management tool for the solc Solidity compiler.

https://solcx.readthedocs.io/

MIT License

138 stars 48 forks source link

use shutil.move instead of os.rename to avoid crashes during install #146

Closed RomiRand closed 10 months ago

RomiRand commented 2 years ago

os.rename crashes in certain scenarios (just happened to me), see the python docs. shutil.move handles these cases better, also see this question on stackoverflow.

What I did

Replaced os.rename with shutil.move.

Checklist

[x] I have confirmed that my PR passes all linting checks
[ ] I have included test cases
[ ] I have updated the documentation (README.md)
[ ] I have added an entry to the changelog