ApeWorX / py-solc-x

Python wrapper and version management tool for the solc Solidity compiler.
https://solcx.readthedocs.io/
MIT License
138 stars 48 forks source link

Solcx installs x86 binary on M1 Mac #152

Open ghost opened 2 years ago

ghost commented 2 years ago

Environment information

What was wrong?

Installed py-solc-x and tried to install latest solc via:

>>> import solcx
>>> solcx.install_solc()

Ended up with:

image

How can it be fixed?

It seems a few years back there was a PR to fix a similar issue, and automatically compile solc from source on ARM computers like the M1 Macs. At some point later, however, it seems like the download URL was hardcoded to the path of the amd64 binary and the specific _install_solc_arm() function removed in later commits db7c859ecd7d8a657ec0475af7a54e98ac844bd1, 54eb45235c8283ec6fd64e0ccff3de4fb4228172

With the original fix from the PR, the path for ARM installation was to just compile solc from source. I imagine this route can be taken again, it just needs to be added to the branch that runs for macOS installation.