feat!: use `packaging.Version` and other fixes and Ape-ifications - Githubissues

ApeWorX / py-solc-x

Python wrapper and version management tool for the solc Solidity compiler.

https://solcx.readthedocs.io/

MIT License

141 stars 49 forks source link

feat!: use `packaging.Version` and other fixes and Ape-ifications #161

Closed antazoey closed 11 months ago

antazoey commented 11 months ago

What I did

Major dust off of this package to try and get it moving again.

refactor: switch from semantic_version to packaging.Version to properly handle RC versions.
fix: an issue with Yul optimize kwargs not working as expected
fix: an issue where --help command expected the wrong result code for some solc versions
chore: all mypy issues and general type fixes
refactor: switch to markdown docs and google-style (adhere to rest of ApeWorX norms)

fixes: #145 fixes: #147

How I did it

How to verify it

Checklist

[ ] I have confirmed that my PR passes all linting checks
[ ] I have included test cases
[ ] I have updated the documentation (README.md)
[ ] I have added an entry to the changelog

github-advanced-security[bot] commented 11 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.