ApeWorX / py-solc-x

Python wrapper and version management tool for the solc Solidity compiler.
https://solcx.readthedocs.io/
MIT License
138 stars 48 forks source link

fix: issue where always warned #164

Closed antazoey closed 7 months ago

antazoey commented 8 months ago

What I did

Issue where would always warn after installing because of hash suffix.

How I did it

How to verify it

Checklist

antazoey commented 8 months ago

you can see the problems in ape-solidity CI output:

tests/test_compiler.py::test_compile[SpacesInPragma]
tests/test_compiler.py::test_compile_missing_version
  /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/solcx/install.py:714: UnexpectedVersionWarning: Installed solc version is v0.8.23+commit.f704f362, expecting v0.8.23
    warnings.warn(

tests/test_compiler.py::test_compile[SpacesInPragma]
  /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/solcx/install.py:714: UnexpectedVersionWarning: Installed solc version is v0.8.12+commit.f00d7308, expecting v0.8.12
    warnings.warn(

tests/test_compiler.py::test_compile[SpacesInPragma]
  /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/solcx/install.py:714: UnexpectedVersionWarning: Installed solc version is v0.8.14+commit.80d49f37, expecting v0.8.14
    warnings.warn(

tests/test_compiler.py::test_compile[SpacesInPragma]
  /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/solcx/install.py:714: UnexpectedVersionWarning: Installed solc version is v0.5.16+commit.9c3226ce, expecting v0.5.16
    warnings.warn(

tests/test_compiler.py::test_compile[SpacesInPragma]
  /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/solcx/install.py:714: UnexpectedVersionWarning: Installed solc version is v0.4.26+commit.4563c3fc, expecting v0.4.26
    warnings.warn(

tests/test_compiler.py::test_compile_solc_not_installed
  /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/solcx/install.py:714: UnexpectedVersionWarning: Installed solc version is v0.6.12+commit.27d51765, expecting v0.6.12
    warnings.warn(

(https://github.com/ApeWorX/ape-solidity/actions/runs/7426784048/job/20211201532)

github-actions[bot] commented 7 months ago

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.