search

ApeironTsuka / node-webpmux

A mostly 1:1 re-implementation of webpmux as a Node module in pure Javascript. Only thing currently missing is a command-line version.
GNU Lesser General Public License v3.0
28 stars 8 forks source link

Issues with Node version #16

Closed PurpShell closed 3 years ago

PurpShell commented 3 years ago

Hey Apeiron! Thanks for working on reducing the node version requirements to run this package. Surpsingly, the issue still persists after removing private field declarations in 3.1.0

PurpShell commented 3 years ago

"#convertToExtended() {" SyntaxError: Unexpected token ' ( ' in node_modules/node-webpmux/webp.js in line 441" is the issue, not sure if it is related to private fields :V

PurpShell commented 3 years ago

A user using REPL.it is also facing the issue, note that he selected node-14, not sure how we are going to diagnose this :/

pedroslopez/whatsapp-web.js#798

ApeironTsuka commented 3 years ago

That particular error means they're definitely not using 3.1.0. As for it not working in Safari.. that I have no idea without more information as I don't have Safari to test with.

PurpShell commented 3 years ago

well i think they updated before you did. We seem to have fixed the issue! I am pretty confused atm lol, seems like npm has done some shenanigans (^3.0.0 wasn't the same as ^3.1.0). Have a good day! Also if you would like to talk, talk to me on discord: PurpShell#0001