Aperta-project / Aperta

A platform for managing the submission and review of research outputs
MIT License
11 stars 7 forks source link

Empowerment/circle fixes #4081

Closed egh closed 6 years ago

egh commented 6 years ago

JIRA issue: None

What this PR does:

Our builds seem to be failing on circle. I'm guessing this is due to the firefox 60 upgrade.

I upgraded the selenium webdriver, but then geckodriver stopped working. So I updated geckodriver-helper, but this is broken in the latest version on Linux. (https://github.com/DevicoSolutions/geckodriver-helper/pull/6)

So I dropped geckodriver helper, which was kind of silly anyhow, and downloaded geckodriver directly from github.

Reviewer tasks (these should be checked or somehow noted before passing on to PO):

benjaminkreen commented 6 years ago

i forgot to purge geckodriver-helper by gem uninstall geckodriver-helper