ENG-810 Ad hoc card export - Githubissues

Aperta-project / Aperta

A platform for managing the submission and review of research outputs

MIT License

11 stars 7 forks source link

ENG-810 Ad hoc card export #4150

Closed egh closed 3 years ago

egh commented 3 years ago

JIRA issue: https://jira.plos.org/jira/browse/ENG-810

What this PR does:

Add basic ad-hoc card export
Exports card attachments
Includes the phase name in the task name for export to make which card it is clearer

Notes

I upgraded the ruby in .ruby-version to 2.4.10 because I could no longer install 2.3.x on my ubuntu 20.04 laptop.

Code Review Tasks:

Author tasks (delete tasks that don't apply to your PR, this list should be finished before code review):

Reviewer tasks (these should be checked or somehow noted before passing on to PO):

[ ] I read through the JIRA ticket's AC before doing the rest of the review
[ ] I ran the code (in the review environment or locally). I agree the running code fulfills the Acceptance Criteria as stated on the JIRA ticket
[ ] I read the code; it looks good
[ ] I have found the tests to be sufficient for both positive and negative test cases

sgatchell commented 3 years ago

looks good to me! Just had a question about strange cards but not a showstopper