Remove rclpy from apex_launch - Githubissues

ApexAI / apex_rostest

Framework for ROS2 Integration Testing

5 stars 6 forks source link

Remove rclpy from apex_launch #22

Closed pbaughman closed 5 years ago

pbaughman commented 5 years ago

Take out dependency on ros2launch API
Add CI job that will run nightly and fail if rclpy gets introduced as a dependency
Add a job to make sure we stay compatible with ros-crystal
Add a test for the new copy/pasted 'print arguments' functionality

Note for Reviewer

We're compatible with ROS crystal now! The README.md has been updated accordingly

This PR addresses https://github.com/ApexAI/apex_rostest/issues/14

Look at this CI pipeline to see the 'isloated' build and test job run (from before I changed it to 'scheduled only': https://gitlab.com/ApexAI/apex_rostest/pipelines/50254676

pbaughman commented 5 years ago

@jpsamper2009 Can you glance at my gitlab-ci.yaml changes and approve? The print_arguments stuff was taken from here: https://github.com/ros2/launch/blob/632ef1f3eca7dbc54fbed85ab65a5efc512d83ed/ros2launch/ros2launch/api/api.py#L91-L114 to remove a dependency