search

ApexAI / apex_rostest

Framework for ROS2 Integration Testing
5 stars 6 forks source link

Fix exception with process name resolution, add test #36

Closed pbaughman closed 5 years ago

pbaughman commented 5 years ago

Fixes #35

Before this fix, if you tried to assert that a process exited before it had been launched, the assert would blow up. assertWaitForShutdown is designed to catch a NoMatchingProcessException and retry, but part of making a NoMatchingProcessException is formatting the error message which would fail if you tried to do it before the process launched

This fix improves _proc_to_name_and_args to handle the case where the process has not launched yet. Two regression tests were added as well.

pbaughman commented 5 years ago

@jpsamper2009 Discovered this issue while writing some new tests

pbaughman commented 5 years ago

Migrated in this PR Remove needs upstream merge tag once it's merged