ApexAI / apex_rostest

Framework for ROS2 Integration Testing
5 stars 6 forks source link

Add gitlab ci #8

Closed pbaughman closed 5 years ago

pbaughman commented 5 years ago

Depends on https://github.com/ApexAI/apex_rostest/pull/6. Rebase this after it's merged so there won't be 77 files changed

Take a look at an example HTML report generated from this job


This change is Reviewable

pbaughman commented 5 years ago

@left4taco I'm done touching this - you can review now

t0ny-peng commented 5 years ago

@pbaughman I've done my review. Please address my comments and then ping me here. Thanks.

pbaughman commented 5 years ago

@left4taco Replied to comments. The only tricky one is the artifacts from the test_all job. I need the .coverage files to persist over to the 'coverage' job and they live in alongside the source files

t0ny-peng commented 5 years ago

@pbaughman I've added more to the review. Please push your change and ping me. Thanks.

pbaughman commented 5 years ago

@left4taco Ok, I think that takes care of everything

t0ny-peng commented 5 years ago

@pbaughman All look good to me. Please let Dejan to approve this PR and then you can merge. Thanks.