Record version hash - Githubissues

ApexAI / performance_test

**This project is deprecated** Go to https://gitlab.com/ApexAI/performance_test

64 stars 41 forks source link

Record version hash #93

Closed pbaughman closed 5 years ago

pbaughman commented 5 years ago

Bake performance_test into the perf_test EXE so it can show up as part of the report
Have the perf_plot tool recognize the version and print it in the "test setup" section of the report
Remove duplciate QOS settings from the 'test setup' section of the report

I also tested what happens if you blow away the .git directory and build performance_test. The tool will still build, but the version shows up as blank.

Here is a report generated with the changes in this PR:

This change is

daggarwa commented 5 years ago

@pbaughman Everything looks okay. As a last thing, can you please rebase off the latest master and also squash the commits into one?

Side note : This is not in the scope of this PR. While testing for the performance test version to be printed in the report from the perfplot tool I encountered an issue which just occurred one time. The perfplot tool failed to plot the attached csv. Attaching the csv and error log for further investigation.

log_Array16k_08-10-2019_10-50-43.txt error_perfplot.txt

pbaughman commented 5 years ago

@daggarwa This is already rebased off of the latest master, and we can select the "squash and merge" option using the little down arrow next to the "Merge Pull Request" button after this is approved.

Here's the current history:

2019-10-03 12:43 Pete Baughman           o [record_version_hash] {origin/record_version_hash} Address lint errors                       
2019-10-03 09:52 Pete Baughman           o performance plotter updates
2019-10-02 15:44 Pete Baughman           o Bake the githash into performance_test
2019-10-07 18:36 deeplearningrobotics    M─┐ [master] {origin/master} {origin/HEAD} Merge pull request #88 from ApexAI/3290-ros2-waitset
2019-09-10 15:40 Divya Aggarwal          │ o {origin/3290-ros2-waitset} Added ROS2 Polling Subscription plugin to performance test
2019-10-07 13:37 deeplearningrobotics    M─┤ Merge pull request #94 from ApexAI/3290-fix_variance

daggarwa commented 5 years ago

@daggarwa This is already rebased off of the latest master, and we can select the "squash and merge" option using the little down arrow next to the "Merge Pull Request" button after this is approved.

@pbaughman Okay great. Sounds good to me. Approving.