ApfelRauber / StackedTrims

Other
2 stars 1 forks source link

Trims display selectively in inventory but do not in game. #4

Closed DagothUrTheFalse closed 1 year ago

DagothUrTheFalse commented 1 year ago

In inventory trims display oddly, legs not visible if all armor is equipped, the helmet and boots if i take off the chestplate, and removing pants will make the helms trims show back up. Nothing else seems to effect it.

2023-07-16_11 50 48 2023-07-16_11 50 52 2023-07-16_11 54 16 2023-07-16_11 54 22

DagothUrTheFalse commented 1 year ago

Something to do with the 2 different textures used for armor is my best guess.

ApfelRauber commented 1 year ago

Seems to be an issue with your texture pack since I could not reproduce this bug. What texture pack are you using? And could you try to redo the screenshots/reproduce this bug with the vanilla texture pack? I'd like to know if this is because of my mod, your texture pack or something else.

ApfelRauber commented 1 year ago

grafik grafik grafik grafik

DagothUrTheFalse commented 1 year ago

It may be due to a different mod as I do have several installed.

2023-07-16_12 37 58 2023-07-16_12 37 42

ApfelRauber commented 1 year ago

Can you send a list of the mods? (A screenshot of your mods folder is fine)

DagothUrTheFalse commented 1 year ago

Sorry i know its alot of mods.

Screenshot_20230716_164528

DagothUrTheFalse commented 1 year ago

Odd fix but the problem wholey disappears when installing the mod AllTheTrims (different trim and resource pack used but i have double checked the issue is still present without allthetrims and without the resource pack). The issue and the fix of using AllTheTrims also seem to be present when using the similar mod Stackable Trims which was inspired by Stacked trims.

2023-07-17_11 47 18 2023-07-17_11 49 30

ApfelRauber commented 1 year ago

Really weird, I'll see what I can do about this bug tomorrow (ish).

ApfelRauber commented 1 year ago

So: This is a bug with immediatelyFast where they use Overwrite (https://github.com/RaphiMC/ImmediatelyFast/blob/1.20/src/main/java/net/raphimc/immediatelyfast/injection/mixins/core/MixinArmorFeatureRenderer.java), so I can't really do anything about this.