Open jimkberry opened 3 years ago
We no longer set the P2pNet channel localData
to null - it was ugly having null
as the peer-specific channel data for remote peers. On the other hand, it's now just set to a constant placeholder string and not used for anything.
We could pass the local peer's version of the channelInfo
- and I guess it could be used for making sure everyone is on the same page? Seems like a waste, tho.
Part of this might be an apian issue, but since p2p "hello" data is now district per-channel, for Beam there are 2 different levels of P2p hello data, and the addition JoinGroupRequest data. So there's:
Currently we:
Note that BeamNetworkPeer and BeamPlayer are both application-defined class, and are pretty much identical.
Yuk.