search

Apicurio / apicurio-registry

An API/Schema registry - stores APIs and Schemas.
https://www.apicur.io/registry/
Apache License 2.0
609 stars 269 forks source link

Adding max life connection property to RegistryDatasourceProducer #5507

Closed Yoni-Weisberg closed 1 week ago

Yoni-Weisberg commented 1 week ago

This mitigates https://github.com/Apicurio/apicurio-registry/issues/5458

Yoni-Weisberg commented 1 week ago

I think the workflow fails are not related to the changes I made. Can you please check?

jsenko commented 1 week ago

hi @Yoni-Weisberg thank you for the PR. It looks unrelated, we'll check.

carlesarnal commented 1 week ago

Hey @Yoni-Weisberg,

Thanks for the contribution. This would for sure fix the issue, but I'm planning a general approach that would solve not only this property but also add the ability to configure any other jdbc-related property. We cannot merge this since that would imply yet another property to maintain in the properties file in the Registry 3.0 lifetime, and we really want to avoid that where possible. As a result, I'm closing this PR, I'll link the new one with the fix as soon as I have it ready.

Yoni-Weisberg commented 1 week ago

Hi @carlesarnal. Thanks for the response I understand this. How long will it take to implement the general fix? Currently there is no workaround for this, and the product is effectively broken.

EricWittmann commented 1 week ago

@Yoni-Weisberg for tracking:

EricWittmann commented 1 week ago

I have it scheduled for 3.0.4, hopefully @carlesarnal agrees.

carlesarnal commented 1 week ago

I do agree, yes. It's already solved on main, so it will be included in the next release.