search

Apicurio / apicurio-studio

Open Source API Design
https://www.apicur.io/studio/
Apache License 2.0
983 stars 493 forks source link

Feedback on OpenShift Template #282

Open sherl0cks opened 6 years ago

sherl0cks commented 6 years ago

Hey @EricWittmann. Based on our convo last week, I gave the template a go. This is a great start, here are my thoughts from the experience:

  1. It would be nice to allow users to delegate to OpenShift to generate route URI's. This is common practice in non-production settings (e.g. not required https://github.com/Apicurio/apicurio-studio/blob/master/distro/openshift/apicurio-template.yml#L782). This would likely mean that either there is an external automation tool like ansible to use the OpenShift API to discover those generated routes and then pass it to the subsequent templates, or it would need the deployed Java processes are smart enough to do that service discovery themselves when configured in a certain OpenShift mode of operation.
  2. Keycloak required some manual config in the admin console, which also meant I needed to create a new secured route to the admin console. Maybe this wont be needed if I can create the route correct the first go around? Keycloak config mgmt seems a bit tricky.
  3. I still can't figure out where your API routes are for the API server. It would be nice to deploy Swagger UI or the like in the root path of your API server just so I can confirm the thing is up and running without having to know much about it.
  4. once I got all the routes set up right, things worked pretty darn well!

Time permitting, I'm going to explore an approach that:

EricWittmann commented 6 years ago

Hey Justin. Have you guys made any progress on this? Also did Hugo Guerrero reach out to you about it? I think he has a similar interest.

sherl0cks commented 6 years ago

@EricWittmann nope =(, but not for lack of want.

I have not heard from Hugo Guerrero.

@jeremyrdavis, please be advised. This would be an important first step in our discussions