search

Apicurio / apicurio-ux-design

Track design work for the Apicurio UI/UX.
Apache License 2.0
0 stars 0 forks source link

Define New Data Type - Checkboxes should be squares #39

Closed Mgranfie closed 5 years ago

Mgranfie commented 5 years ago

The circle check does not imply checkbox behavior and could easily be considered option buttons. These also do not align to PatternFly card UI Standards. screen shot 2018-10-23 at 11 48 36 am

EricWittmann commented 5 years ago

Those cards are radio buttons (mutually exclusive options). I think the circles are correct.

Mgranfie commented 5 years ago

@EricWittmann oh right... Ok can we use the option buttons here to support the mutual exclusivity :)

EricWittmann commented 5 years ago

Oh right - I forgot to change that icon from "fa-check-circle-o" to "fa-dot-circle-o". I've done that now so it'll be correct in the next version of Apicurio.

EricWittmann commented 5 years ago

Looks like this now:

image

Mgranfie commented 5 years ago

Awesome!!

On Wed, Oct 24, 2018 at 9:57 AM, Eric Wittmann notifications@github.com wrote:

Looks like this now:

[image: image] https://user-images.githubusercontent.com/1890703/47435704-282c4180-d773-11e8-96ea-b6c6b5b83315.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Apicurio/apicurio-ux-design/issues/39#issuecomment-432667642, or mute the thread https://github.com/notifications/unsubscribe-auth/ARTwqzxN4c14O_nfCcYHmQiQTtuJ2aVbks5uoHGygaJpZM4X154B .