search

Apicurio / srs-fleet-manager

Implementation of the Managed Service Registry Service API (aka control plane API).
Apache License 2.0
4 stars 13 forks source link

Apicurio dependencies version mistmatch in MAS env #176

Open famarting opened 3 years ago

famarting commented 3 years ago

We are using version 2.1.0.Final for the tenant-manager client https://github.com/bf2fc6cc711aee1a0c2a/srs-fleet-manager/blob/fc60b158c1307a69f28019b85d9392ba56c65ed3/pom.xml#L37

But in MAS we did change the srs-service-registry repo to 2.1.0.MAS https://gitlab.cee.redhat.com/service-registry/srs-service-registry/-/commit/5d2ff2f487df3469e94673806d82d5307b56bb73

This is not causing any issues for now because we did not change the tenant-manager client apis nor nothing related, but we need to make srs-fleet-manager to use that 2.1.0.MAS version, the thing is where to make the change? and if we do it directly in gitlab, will it be overwritten by the sync automation?

famarting commented 3 years ago

@EricWittmann @riprasad FYI

EricWittmann commented 3 years ago

You raise a good point. I'm not sure what the right answer is. The 2.1.0.MAS version is downstream only of course - is the built artifact available in some way (certainly not maven central) for the fleet manager to pull it in?

jsenko commented 3 years ago

Maybe we can create a "downstream" build profile, with the downstream version property, and a downstream repository definition? Not sure where the repo would live though.

famarting commented 3 years ago

currently we just build the required maven deps https://github.com/bf2fc6cc711aee1a0c2a/srs-fleet-manager/blob/main/Makefile#L21