Boolean validation failing

Apipie / apipie-rails

Ruby on Rails API documentation tool

Apache License 2.0

2.47k stars 463 forks source link

Boolean validation failing #748

Closed colinbruce closed 2 years ago

colinbruce commented 2 years ago

Since the release of 0.7.0 and the merging of #733 we've seen some errors with boolean paramteters.

pry(#<Apipie::ParamDescription>)> false.blank?
=> true

Therefore when sending a param with a value of false, not "false", it fails before even calling the validate method of BooleanValidator I'm working on a fix, and will try and open a PR soon

colinbruce commented 2 years ago

PR #749 hopefully addresses this issue with some tests to cover it 👍