search

Apipie / apipie-rails

Ruby on Rails API documentation tool
Apache License 2.0
2.47k stars 461 forks source link

Bump ruby versions on test jobs #927

Closed m-nakamura145 closed 4 months ago

m-nakamura145 commented 4 months ago

Use latest ruby versions on test jobs

ekohl commented 4 months ago

I have never seen this before in a Gemfile: https://github.com/Apipie/apipie-rails/blob/f300fcc27c7805bcce54b6e02d147bd15931ab12/Gemfile#L8

Reading https://bundler.io/v2.5/man/gemfile.5.html#RUBY I don't really see the point of this. There is already a declaration for compatible versions here: https://github.com/Apipie/apipie-rails/blob/f300fcc27c7805bcce54b6e02d147bd15931ab12/apipie-rails.gemspec#L14

So I'd propose to drop that line from the Gemfile.

m-nakamura145 commented 4 months ago

@ekohl I agree with you. removed 733193d

mathieujobin commented 4 months ago

@ekohl I've been doing squash merge for a few years now, I think we should stick with squash merge on this projct.