search

ApmeM / android-flowlayout

Linear layout, that wrap its content to the next line if there is no space in the current line.
2.03k stars 370 forks source link

The layout does not respect child margins #47

Closed karlicoss closed 9 years ago

karlicoss commented 9 years ago

Not actually a pull request, but would be easier for you to observe the bug that way, just modified the demo app a bit. So, there is kinda minimal not-working example app, you can enter the text in the field and then add it via one of two buttons. The "Add unwrapped" button adds my layout (see R.layout.child) to the FlowLayoyt as is, whereas "Add wrapped" adds this layout wrapped in a dummy FrameLayout (see R.layout.child_wrapped) And here's my (annotated) screenshot. The first child layout was added via the "Add unwrapped" button, the second via the "Add wrapped" button, the first's layout right margin is not respected, whereas the second's margin is respected (since wrapping FrameLayout has no margins at all). You have any idea what am I doing wrong, or it is indeed a bug? I don't have much time right now, so I could live with a wrapping layout solution for a while, but if it is a bug, I could even try to fix that later. Thanks in advance.

karlicoss commented 9 years ago

hm, I guess that might be somehow related https://github.com/ApmeM/android-flowlayout/issues/39

ApmeM commented 9 years ago

Original issue was tested and fixed. Thank you.