search

Apollo-Roboto / discord.py-ext-prometheus

Add Prometheus to your Discord bot with this handy extension
https://pypi.org/project/discord-ext-prometheus/
MIT License
15 stars 5 forks source link

Add units to LATENCY_GAUGE #15

Closed 2br-2b closed 3 weeks ago

Apollo-Roboto commented 4 weeks ago

Apologies for not getting to this pull request sooner, it's difficult to understand your motives without a description.

Can you explain the reason you need to add this parameter, was there an issue without it?

2br-2b commented 3 weeks ago

Hey! Not a problem!

There isn't a problem. This works fine; this just adds a units flag to the Prometheus entry.

Thanks for the sample code btw! It's really helped up my bot's monitoring

Apollo-Roboto commented 3 weeks ago

All good, I'll be merging this.

The dashboard will need to be updated since this changes the metric name from discord_latency to discord_latency_seconds. That change will be in 0.2.0

Apollo-Roboto commented 3 weeks ago

Version 0.2.0 is up with your changes, make sure to update your dashboards.

Thanks for the contribution!