search

Apollo3zehn / FluentModbus

Lightweight and fast client and server implementation of the Modbus protocol (TCP/RTU).
MIT License
189 stars 71 forks source link

Remove private protected #36

Closed robeving closed 3 years ago

robeving commented 3 years ago

Having this marked as private protected is annoying is it means I can't implement my own ModbusServer instance handling my custom transport layer

https://github.com/Apollo3zehn/FluentModbus/blob/ca56ca4c3d6f0a364b277fb37d5f076828e7908a/src/FluentModbus/Server/Mo dbusServer.cs#L297

Apollo3zehn commented 3 years ago

You are right, that should be made accessible. Do you only need that method unprotected? If yes I will create an update tomorrow morning.

robeving commented 3 years ago

I'lll send you a PR

robeving commented 3 years ago

Also thanks for the library, works well for me!