Closed danbraunai-apollo closed 9 months ago
Agree forbidding extra arguments is probably good. Sometimes it will mess things up if we remove config arguments then try to load old configs, but I think we don't care very much.
Separately, it would be nice if modular arithmetic dataset supported these arguments, but that's another issue.
We currently have e.g.
But this doesn't prevent one from passing extra arguments like "return_set_frac" to this class. We would like it to prevent this.
We just need
model_config = ConfigDict(extra="forbid")
in all the relevant classes (I think probably every pydantic class)