search

ApolloResearch / rib

Library for methods related to the Local Interaction Basis (LIB)
MIT License
3 stars 0 forks source link

Add svd basis #239

Closed nix-apollo closed 9 months ago

nix-apollo commented 9 months ago

Svd basis

Description

Allow basis_formula: svd which will use the values of Us as Cs.

Related Issue

Closes #184

Motivation and Context

How Has This Been Tested?

Added a simple test that ensures Us and Cs are identical.

Does this PR introduce a breaking change?

No.

stefan-apollo commented 9 months ago

This looks good, and great implementation! I'd like to make a mod add plot reproducing yours from here and then happy to merge! Will do this quickly

stefan-apollo commented 9 months ago

Hmmm looks different but the style is similar -- I'd say this is fine given the other changes in the code, happy to merge! image