ApolloResearch / rib

Library for methods related to the Local Interaction Basis (LIB)
MIT License
2 stars 0 forks source link

Utility to get rib activations #242

Closed nix-apollo closed 10 months ago

nix-apollo commented 10 months ago

Rib acts

Description

Related Issue

Motivation and Context

I find myself wanting rotated rib activations a bunch. I think it's nice to have a central place for these sorts of utilities.

How Has This Been Tested?

I added a test that calls get_rib_acts and compares them with a more manual computation of rib activations. This isn't a very strong test as it is in essence doing the same test twice, but it at least ensures get_rib_acts runs without errors.

Does this PR introduce a breaking change?

No.

nix-apollo commented 10 months ago

CI tests are maybe slower in this branch than on main, although it's not entirely clear to me. I think the last couple commits did improve things (as I'm no longer caching all activations on pythia).

nix-apollo commented 10 months ago

Yup that one was only ~5m. I think tests are just variable in timing, and also run_with_cache on pythia is a mistake.