search

ApolloResearch / rib

Library for methods related to the Local Interaction Basis (LIB)
MIT License
2 stars 0 forks source link

Add get_config functions to test_build_graph #256

Closed nix-apollo closed 10 months ago

nix-apollo commented 10 months ago

Config creation functions

Description

Cleaning up repetitive config declarations in tests

Related Issue

Motivation and Context

I think it's mildly nicer to read the test file and add new tests.

How Has This Been Tested?

Tests pass, but no new tests added.

Does this PR introduce a breaking change?

No.

stefan-apollo commented 10 months ago 
# TODO: this fails for layers.0 but shouldn't (afaik)

I don't have enough context on this one, it's a question for @stefan-apollo. Can leave for now

This should not fail based on RIB assumptions, though I think we have an issue somewhere to debug this? It occurs at various places

stefan-apollo commented 10 months ago

Ah it's issue #241