ApolloResearch / rib

Library for methods related to the Local Interaction Basis (LIB)
MIT License
3 stars 0 forks source link

MLP rib build -> ablation pipeline is broken. #259

Closed nix-apollo closed 8 months ago

nix-apollo commented 8 months ago

This change is breaking for run_mlp_ablations, as run_mlp_ablations expects to find mlp config information at results["model_config"]["model"]. Instead mlp rib build now stores only the mlp config info, omitting mlp training config, etc.

nix-apollo commented 8 months ago

Probable change is to go back to storing training information, etc in rib results. But I'm unsure what's best for consistency with modular mlp and eventually combining ablation scripts

danbraunai-apollo commented 8 months ago

Yeah I think I'd like to have all train information stored in the results. I'm going to work on this now and make a PR to main, since I'd like to have this in the refactor.

danbraunai-apollo commented 8 months ago

OK I decided against this to keep things consistent with lms. Otherwise it's a bit messier.