search

ApolloResearch / rib

Library for methods related to the Local Interaction Basis (LIB)
MIT License
3 stars 0 forks source link

Node spacing broken for 1st layer? #271

Closed stefan-apollo closed 5 months ago

stefan-apollo commented 7 months ago

The plotting code contains the line

        # Add extra spacing for nodes that have fewer nodes than the biggest layer
        spacing = 1 if i == 0 else max_layer_height / len(layer)

which messes up i==0 (the first layer) image

If I remove this line

        # Add extra spacing for nodes that have fewer nodes than the biggest layer
        spacing = max_layer_height / len(layer)

everything seems better: image

Chesterton's fence: Is there a reason we had this, or can we remove the if statement?

nix-apollo commented 5 months ago

Fixed in #348. I'm still not sure what the original reason for this was, but it was no longer useful.