search

ApolloZhu / Dynamic-Dark-Mode

The smart, automatic Dark Mode toggle for macOS Mojave+
https://apollozhu.github.io/Dynamic-Dark-Mode/
GNU General Public License v3.0
504 stars 31 forks source link

Sunset/Sunrise setting #15

Closed jan-xyz closed 6 years ago

jan-xyz commented 6 years ago

I really like the app! I think it would be really cool if the app used the same logic as the dynamic wallpapers to switch between day and night. The wallpaper uses azimuth and altitude to determine if the sun is above or below the horizon at your current location.

@mczachurski explains it very well in his blog post for his wallpaper tool.

jan-xyz commented 6 years ago

Nevermind I just found it in the settings but I get an error

screenshot 2018-09-28 at 21 03 45
jan-xyz commented 6 years ago

After closing and opening it a couple of times it started working. Now I can't get it to not work anymore. It's probably something that can be made a bit more robust and might be an initial setup problem.

ApolloZhu commented 6 years ago

Thanks for the feedback! I haven't got a chance to test the app yet, but I will check what's going on with the location processing code.

And yeah I don't think we need azimuth & attitude; sunset/sunrise time is good enough.

jan-xyz commented 6 years ago

Yeah, might be cool if it even stays in sync with the dynamic wallpaper. I imagine they can be a bit out of sync if they use different services, I'm not sure if it's possible to hook into it, especially considering that you want to stay away from private APIs.

ApolloZhu commented 6 years ago

@jan-xyz Do you mind testing out the new, 1.0.3 release? It should be alright except having error -1751 sometimes.

The new version has a setup process that asks for access to location, that should? solve the problem of not been able to access location when it first launches. You can re-run that process by using the re-setup button in the preferences pane, or you can check to see if you allowed Dynamic to access location through System Preferences.

You may reset preferences for this app by running this in the terminal: defaults delete io.github.apollozhu.Dynamic

If it's still not working for you, please let me know (and possibly, with more details.)

ApolloZhu commented 6 years ago

Please reopen if you are still experiencing this issue.