search

ApolloZhu / Dynamic-Dark-Mode

The smart, automatic Dark Mode toggle for macOS Mojave+
https://apollozhu.github.io/Dynamic-Dark-Mode/
GNU General Public License v3.0
504 stars 31 forks source link

Touch Bar Support #4

Closed ApolloZhu closed 6 years ago

ApolloZhu commented 6 years ago

I don't have a Touch Bar...

uetcis commented 6 years ago

So what are you going to do with a Touch Bar?

ApolloZhu commented 6 years ago
  1. That toggle button in the menu bar...

When settings panel is visible

  1. Map settings to Touch Bar actions
AutinMitra commented 6 years ago

If you don't have a Touch Bar, you can use Touché. It puts the Touch Bar on the screen (and shows specialized controls for apps).

ApolloZhu commented 6 years ago

Thank you for your suggestions, but Xcode does have a Touch Bar simulator built in. My main concern is that my design is not what the Touch Bar users are familiar with, as I have never used it before.

AutinMitra commented 6 years ago

I would add the toggle button to the control strip (can be accessed via private FW: NSTouchbar System Tray). The only problem would be confusion with the brightness icon, but that can be fixed by using color for the touch bar icon. I wouldn't use the middle section of it for toggling, but maybe for adjusting preferences.

ApolloZhu commented 6 years ago

Thank you for your suggestion! Appreciate it!

AutinMitra commented 6 years ago

My spaghetti code (DarkM) has the toggle from the TouchBar, should be easy to implement in Dynamic. Using the control strip also allows for the TouchBar toggle to still be there with the app in the background.